Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE]: 온점 삭제 및 ~다 체를 ~요 체로 변경 #444

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

BadaHertz52
Copy link
Contributor


🚀 어떤 기능을 구현했나요 ?

  • 말끝에 온점을 삭제했어요.
  • 사용자 화면에 나타나는 메세지 중 ~다체로 끝나는 말을 ~요체로 변경했어요.

🔥 어떻게 해결했나요 ?

  • vscode 찾기 변경 기능에게 감사를

📝 어떤 부분에 집중해서 리뷰해야 할까요?

  • 변경해야하는 부분이 더 없는지, 있다면 말씀해주세요.

📚 참고 자료, 할 말

  • 오늘 반드시 칼퇴를 한다 (영어 수업이 있기는 하지만)

Copy link
Contributor

@soosoo22 soosoo22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~요 체로 통일하는 거 너무 좋은 것 같아요 수고했어요 바다!

@@ -32,7 +32,7 @@ const ReviewDescription = ({
<S.ProjectName>{projectName}</S.ProjectName>
<S.RevieweeNameAndDateContainer>
<S.RevieweeNameWrapper>
<S.RevieweeName>{revieweeName}</S.RevieweeName>에 대한 리뷰입니다!
<S.RevieweeName>{revieweeName}</S.RevieweeName>에 대한 리뷰에요
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

에요->예요로 수정 부탁해요!

@@ -23,7 +23,7 @@ const ReviewZonePage = () => {
paramKey: 'reviewRequestCode',
});

if (!reviewRequestCode) throw new Error('유효하지 않은 리뷰 요청 코드입니다.');
if (!reviewRequestCode) throw new Error('유효하지 않은 리뷰 요청 코드에요');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

에요->예요로 수정 부탁해요!

Copy link
Contributor

@ImxYJL ImxYJL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

원장님 감사해요 ^^

@ImxYJL ImxYJL merged commit ab5ca23 into develop Aug 20, 2024
1 of 2 checks passed
@donghoony donghoony deleted the fe/fix/438_delete_period branch August 23, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FE] 점을 뺀다.
4 participants